Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storybook mdx plugin #922

Merged
merged 4 commits into from
Dec 15, 2022
Merged

Fix storybook mdx plugin #922

merged 4 commits into from
Dec 15, 2022

Conversation

rajsite
Copy link
Member

@rajsite rajsite commented Dec 14, 2022

Pull Request

🤨 Rationale

Improves #825. Found that the current "@mdx-js/react": "*" version was resolving in package-lock.json to the latest "@mdx-js/react" at v2 which is an actual breaking change for storybook.

👩‍💻 Implementation

Instead matched the version specifier with the one in the storybook package version and verified that the package-lock only shows one version.

🧪 Testing

Built locally

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@jattasNI
Copy link
Contributor

This is definitely an improvement. Though the Getting Started page still seems to have styling issues (e.g. uses browser default font and image is too big).

I changed the PR description not to resolve #825 but I'm going to complete the PR since it's a step forward. I'll update the issue to describe what needs validating when we update to the next Storybook major version.

@rajsite rajsite merged commit 2309a52 into main Dec 15, 2022
@rajsite rajsite deleted the fix-mdx branch December 15, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants