Skip to content

Commit

Permalink
Bug1070/nidigital remove redundant size param (#1104)
Browse files Browse the repository at this point in the history
* Remove size param from apply_tdr_offsets() and write_source_waveform_broadcast_u32()

* Add test support files

* Updated Changelog

* Remove size param from apply_tdr_offsets() and write_source_waveform_broadcast_u32()

* Updated the os.path.join() call.

* Revert "Add test support files"

This reverts commit fd1c5b6

* Remove newly added system tests
  • Loading branch information
sbethur authored and marcoskirsch committed Nov 12, 2019
1 parent a551a0b commit 6b55bdf
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 26 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ All notable changes to this project will be documented in this file.
* #### Added
* #### Changed
* Fix get/set properties - [#1062](https://github.com/ni/nimi-python/issues/1062)
* Removed array-size parameter from apply_tdr_offsets() and write_source_waveform_broadcast_u32() methods - [#1070](https://github.com/ni/nimi-python/issues/1070)
* #### Removed
* ### NI-TClk
* #### Added
Expand Down
20 changes: 3 additions & 17 deletions docs/nidigital/class.rst
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ apply_tdr_offsets

.. py:currentmodule:: nidigital.Session
.. py:method:: apply_tdr_offsets(num_offsets, offsets)
.. py:method:: apply_tdr_offsets(offsets)
TBD
Expand All @@ -176,16 +176,9 @@ apply_tdr_offsets
.. code:: python
session.channels[0,1].apply_tdr_offsets(num_offsets, offsets)
session.channels[0,1].apply_tdr_offsets(offsets)
:param num_offsets:
:type num_offsets: int
:param offsets:
Expand Down Expand Up @@ -3277,7 +3270,7 @@ write_source_waveform_broadcast_u32

.. py:currentmodule:: nidigital.Session
.. py:method:: write_source_waveform_broadcast_u32(waveform_name, waveform_size, waveform_data)
.. py:method:: write_source_waveform_broadcast_u32(waveform_name, waveform_data)
TBD
Expand All @@ -3292,13 +3285,6 @@ write_source_waveform_broadcast_u32
:type waveform_name: str
:param waveform_size:
:type waveform_size: int
:param waveform_data:
Expand Down
10 changes: 3 additions & 7 deletions generated/nidigital/session.py
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,7 @@ def _get_error_description(self, error_code):
''' These are code-generated '''

@ivi_synchronized
def apply_tdr_offsets(self, num_offsets, offsets):
def apply_tdr_offsets(self, offsets):
r'''apply_tdr_offsets
TBD
Expand All @@ -630,11 +630,9 @@ def apply_tdr_offsets(self, num_offsets, offsets):
You can specify a subset of repeated capabilities using the Python index notation on an
nidigital.Session repeated capabilities container, and calling this method on the result.:
session.channels[0,1].apply_tdr_offsets(num_offsets, offsets)
session.channels[0,1].apply_tdr_offsets(offsets)
Args:
num_offsets (int):
offsets (list of float):
'''
Expand Down Expand Up @@ -3482,16 +3480,14 @@ def write_sequencer_register(self, reg, value):
return

@ivi_synchronized
def write_source_waveform_broadcast_u32(self, waveform_name, waveform_size, waveform_data):
def write_source_waveform_broadcast_u32(self, waveform_name, waveform_data):
r'''write_source_waveform_broadcast_u32
TBD
Args:
waveform_name (str):
waveform_size (int):
waveform_data (list of int):
'''
Expand Down
4 changes: 2 additions & 2 deletions src/nidigital/metadata/functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
'direction': 'in',
'name': 'offsets',
'size': {
'mechanism': 'passed-in',
'mechanism': 'len',
'value': 'numOffsets'
},
'type': 'ViReal64[]'
Expand Down Expand Up @@ -3672,7 +3672,7 @@
'direction': 'in',
'name': 'waveformData',
'size': {
'mechanism': 'passed-in',
'mechanism': 'len',
'value': 'waveformSize'
},
'type': 'ViUInt32[]'
Expand Down

0 comments on commit 6b55bdf

Please sign in to comment.