Add codegen support for using converters to convert parameter of type string sequence to comma-delimited string #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… string sequence to comma-delimited string - Rename convert_repeated_capabilities_from_init() to convert_repeated_capabilities_without_prefix(). Other than its current use for option_string in init(), it will be used for indices in get_channel_names() (#1386) and for initial state parameters in apply_levels_and_timing() (#1391) - Update _get_ctype_variable_definition_snippet_for_string() to add case for string input with converter and special case for NOT using converter in init function
Codecov Report
@@ Coverage Diff @@
## master #1404 +/- ##
==========================================
+ Coverage 91.88% 91.90% +0.01%
==========================================
Files 20 20
Lines 3637 3642 +5
==========================================
+ Hits 3342 3347 +5
Misses 295 295
Continue to review full report at Codecov.
|
marcoskirsch
previously requested changes
Apr 13, 2020
Without the special-case, converters will be called in `_init_function` unnecessarily. This is ok since the any kind of special-casing will add complexity without enough benefit. The redundant call to converters is not a big deal since it happens only once during session init.
marcoskirsch
previously requested changes
Apr 14, 2020
texasaggie97-zz
approved these changes
Apr 14, 2020
marcoskirsch
dismissed
their stale review
Mark said: "I think having a nifake test for the parameter would be nice, but I think the usage in the generated init function (not init) also proves it is working."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- [ ] I've updated CHANGELOG.md if applicable.What does this Pull Request accomplish?
List issues fixed by this Pull Request below, if any.
What testing has been done?
Added new unit tests. Ran all unit tests. CI will run system tests.