Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11 Support #1903

Merged
merged 4 commits into from
Apr 11, 2023
Merged

Conversation

ni-jfitzger
Copy link
Collaborator

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Adds official Python 3.11 support to nimi-python through testing.

List issues fixed by this Pull Request below, if any.

What testing has been done?

None

@ni-jfitzger
Copy link
Collaborator Author

I cancelled the checks because I currently expect them to fail. Updates to nimibot adding Python 3.11 are implemented in an internal PR, but deployment is currently failing.

@ni-jfitzger
Copy link
Collaborator Author

I am excluding grpcio 1.53 from our test dependencies to fix the win32 system test failures.
As part of #1916, I plan to only exclude 1.53 for Python 3.7, but for now, I'm going with a quick and dirty fix.

@ni-jfitzger
Copy link
Collaborator Author

I will await the merge of #1917 to avoid dirtying this commit with an unrelated change.

@marcoskirsch
Copy link
Member

Waiting on Travis CI run.

@ni-jfitzger
Copy link
Collaborator Author

Travis CI run completed. Merging.

@ni-jfitzger ni-jfitzger merged commit 4c34ad1 into ni:master Apr 11, 2023
@ni-jfitzger ni-jfitzger deleted the add-python-3.11-support branch April 11, 2023 18:32
@ni-jfitzger ni-jfitzger mentioned this pull request Jul 11, 2023
2 tasks
This was referenced Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Python 3.11
2 participants