Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating enums_addon and system tests for nifgen #586

Merged
merged 36 commits into from
Nov 22, 2017
Merged

Updating enums_addon and system tests for nifgen #586

Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
955749d
Update enums_addon.py
bhaswath Nov 13, 2017
971ec27
Update test_system_nifgen.py
bhaswath Nov 13, 2017
9a39ad4
fixed failing system test for nifgen and flake-8 failure
injaleea Nov 13, 2017
5462d10
Update enums_addon.py
bhaswath Nov 14, 2017
6c428a2
Update test_system_nifgen.py
bhaswath Nov 14, 2017
b3f3e5d
Update test_system_nifgen.py
bhaswath Nov 14, 2017
4590732
Update enums_addon.py
bhaswath Nov 14, 2017
bdf5ad9
Update functions_addon.py
bhaswath Nov 14, 2017
e613514
Update functions_addon.py
bhaswath Nov 14, 2017
676c708
Update enums_addon.py
bhaswath Nov 14, 2017
0c0b218
Update test_system_nifgen.py
bhaswath Nov 14, 2017
c3e0683
Merge branch 'master' into bhaswath
bhaswath Nov 15, 2017
f49bd8c
Update enums_addon.py
bhaswath Nov 15, 2017
29bc428
Update test_system_nifgen.py
bhaswath Nov 15, 2017
f6d06ff
Update functions_addon.py
bhaswath Nov 15, 2017
41566f5
Update enums_addon.py
bhaswath Nov 15, 2017
cad0577
Update test_system_nifgen.py
bhaswath Nov 15, 2017
a76ca54
Update test_system_nifgen.py
bhaswath Nov 16, 2017
8175cc6
Update enums_addon.py
bhaswath Nov 16, 2017
fdbb288
Merge branch 'master' into bhaswath
bhaswath Nov 17, 2017
174b1dc
Update enums_addon.py
bhaswath Nov 17, 2017
1ffab89
Update functions_addon.py
bhaswath Nov 17, 2017
8338685
Update enums_addon.py
bhaswath Nov 17, 2017
0feb453
Update test_system_nifgen.py
bhaswath Nov 17, 2017
20da0ad
Update test_system_nifgen.py
bhaswath Nov 17, 2017
7d7db9a
Update test_system_nifgen.py
bhaswath Nov 17, 2017
7cd8a42
Update test_system_nifgen.py
bhaswath Nov 17, 2017
58a3cbc
Update test_system_nifgen.py
bhaswath Nov 17, 2017
2eeaf31
Update test_system_nifgen.py
bhaswath Nov 21, 2017
5faf801
Update enums_addon.py
bhaswath Nov 22, 2017
0db1949
Update test_system_nifgen.py
bhaswath Nov 22, 2017
0a3b472
Update test_system_nifgen.py
bhaswath Nov 22, 2017
9d4a7fa
Merge branch 'master' into bhaswath
texasaggie97-zz Nov 22, 2017
5666e73
Don't use session from fixture since we are creating our own
texasaggie97-zz Nov 22, 2017
95aced3
Clean up formatting
texasaggie97-zz Nov 22, 2017
d1ff118
Update generated files
texasaggie97-zz Nov 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/nifgen/system_tests/test_system_nifgen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,6 @@ def test_read_current_temperature(session):
assert session.read_current_temperature() > 25.0



def test_named_waveform_operations(session):
wfm_name = 'Waveform'
wfm_size = 4096
Expand All @@ -164,9 +163,10 @@ def test_named_waveform_operations(session):
session.delete_named_waveform(wfm_name)


def test_adjust_sample_clock_relative_delay(session):
delay = 1e-09
session.adjust_sample_clock_relative_delay(delay)
def test_adjust_sample_clock_relative_delay():
with nifgen.Session('', False, 'Simulate=1, DriverSetup=Model:5421;BoardType:PXI') as session: # 5433 is not supporting adjust_sample_clock_relative_delay right now
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment makes it impossible for us to follow up in the future. Anything that says "right now" can be fixed at some point. So the comment should indicate so either by pointing to an issue or by being a TODO.

In this specific case, however, support has been added to NI-FGEN in 17.8 which will be released soon. I'm going to upgrade nimi-bot to pre-release NI-FGEN 17.8d25. This means you will be able to use 5433 in this test and it should work and hopefully the prerelease software doesn't break anything.

This will leave a window of time between now and NI-FGEN 17.8 being publicly released in which non-NI contributors will have a problem running this system test,

delay = 1e-09
session.adjust_sample_clock_relative_delay(delay)


def test_resets(session):
Expand Down