Add more nifgen systems tests, and retrofit nifgen examples #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoskirsch
requested changes
Nov 15, 2017
|
|
||
|
|
||
| def test_write_waveform_from_filei64(session): | ||
| session.arb_sample_rate = 40000000 |
There was a problem hiding this comment.
There's no need to set sample rate here. Only do the absolute minimum you need to.
| session.arb_sample_rate = 40000000 | ||
| session.create_waveform_from_file_i16(os.path.join(os.getcwd(), 'systemtest_dependencies', 'SineI16BigEndian_1000.bin'), nifgen.ByteOrder.BIG_ENDIAN) # Enable after issue #538 fixed | ||
| sample_rate = session.arb_sample_rate | ||
| assert sample_rate == 40000000''' |
There was a problem hiding this comment.
move the closing ''' to its own line to match how you open it.
|
|
||
| def test_write_waveform_from_filei64(session): | ||
| session.arb_sample_rate = 40000000 | ||
| session.create_waveform_from_file_i16(os.path.join(os.getcwd(), 'systemtest_dependencies', 'SineI16BigEndian_1000.bin'), nifgen.ByteOrder.BIG_ENDIAN) # Enable after issue #538 fixed |
There was a problem hiding this comment.
I would directly put the file next to the system test script, I don't think we need a separate folder.
Alternatively, there may be a really compact way to create this file from the the test when we need it, you could put it in the temp directory.
injaleea
changed the title
marcoskirsch
approved these changes
Nov 16, 2017
marcoskirsch
changed the title
|
I improved the title, and changed the description so that #484 isn't automatically closed. Watch out for those! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[X] This contribution adheres to CONTRIBUTING.md.
[ ] I've updated CHANGELOG.md if applicable.[X] I've added tests applicable for this pull request
What does this Pull Request accomplish?
Adding more system tests for nifgen
Fixed examples to have emus per #553
List issues fixed by this Pull Request below, if any.
Partial towards #484
What testing has been done?
system test, tox