grub2: Backport fix for 2038 bug on FAT fs #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gratian
approved these changes
Aug 28, 2024
chaitu236
force-pushed
the
dev/cvadrevu/grub_2038
branch
from
baa5527 to
326aedb
Compare
A issue was found when I run "runqemu genericx86-64 ovmf", grub failed to boot, it's a known issue has been fixed in grub upstream, backport the fix. Signed-off-by: Ming Liu <liu.ming50@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 51eab4b) Signed-off-by: Chaitanya Vadrevu <chaitanya.vadrevu@ni.com>
chaitu236
force-pushed
the
dev/cvadrevu/grub_2038
branch
from
326aedb to
bfeeb44
Compare
|
v2: Turns out OE upstream master already had this backport https://git.openembedded.org/openembedded-core/commit/meta/recipes-bsp/grub/files?id=51eab4bb0cae46c9c32d28986eb97badf47594b7 before it upgraded to grub 2.12 (at which point the patch was deleted). So just cherry-picked this commit from OE upstream. Sent upstream patch for cherry-picking to kirkstone - https://lists.openembedded.org/g/openembedded-core/topic/kirkstone_patch_grub/108151911 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport commit [1] from upstream to fix grub not being able to detect FAT filesystems containing directories whose modification times are later than 2038.
[1] https://git.savannah.gnu.org/gitweb/?p=grub.git;a=commit;h=e43f3d93b28cce852c110c7a8e40d8311bcd8bb1
WI: AB#2839385
Testing
grub-efirecipe.bootx64.efiwith the one from from grub-efi's ipk and verified that a VM provisioned after 2038 can boot (it used to fail without this fix).Note