Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(asset): compute "Now" in a way that can be saved #107

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

Catalin-web
Copy link
Contributor

@Catalin-web Catalin-web commented Oct 28, 2024

Pull Request

🀨 Rationale

Task: link

πŸ‘©β€πŸ’» Implementation

Added a hardcoded value: ${__now:date}, similar to other grafana variables. This will allow us to save the dashboard, and on reload new date will be computed.

πŸ§ͺ Testing

Added tests+
compute Now in a different way

βœ… Checklist

@Catalin-web Catalin-web marked this pull request as ready for review October 28, 2024 11:30
@Catalin-web Catalin-web merged commit 728d47f into main Oct 29, 2024
1 check passed
@Catalin-web Catalin-web deleted the users/cbugnar/computeNowInADifferentWay branch October 29, 2024 09:50
mure pushed a commit that referenced this pull request Oct 29, 2024
## [3.43.0](v3.42.0...v3.43.0) (2024-10-29)

### Features

* **asset:** compute "Now" in a way that can be saved ([#107](#107)) ([728d47f](728d47f))
@mure
Copy link
Collaborator

mure commented Oct 29, 2024

πŸŽ‰ This PR is included in version 3.43.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@mure mure added the released label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants