Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(assets): fix display for assets in global variable #123

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

kkerezsi
Copy link
Collaborator

@kkerezsi kkerezsi commented Feb 10, 2025

Pull Request

🀨 Rationale

Due to difficulty in readability, we are changing the display for the assets from

Vendor: ${vendor} - Model: ${model} - Serial: ${serialNumber};

To only $(serialNumber)

image

πŸ‘©β€πŸ’» Implementation

Changing the display builder to show only the serial number

πŸ§ͺ Testing

Unit tests

βœ… Checklist

@kkerezsi kkerezsi merged commit 7408f7e into main Feb 10, 2025
1 check passed
@kkerezsi kkerezsi deleted the users/akerezsi/change-display-name-assets branch February 10, 2025 09:22
mure pushed a commit that referenced this pull request Feb 10, 2025
## [3.46.2](v3.46.1...v3.46.2) (2025-02-10)

### Bug Fixes

* **assets:** fix display for assets in global variable ([#123](#123)) ([7408f7e](7408f7e))
@mure
Copy link
Contributor

mure commented Feb 10, 2025

πŸŽ‰ This PR is included in version 3.46.2 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

@mure mure added the released label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants