fix(notebook): fix notebook plugin not loading notebook parameters when opening visualization #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MileaRobertStefan
approved these changes
May 23, 2024
|
Please review the commit message format specified in the README and update this PR title accordingly. |
|
Could you explain your fix a little more? I understand what's happening, but it's not clear why it fixes the issue. |
Catalin-web
changed the title
Catalin-web
changed the title
cameronwaterman
changed the title
|
Since this is a bug fix and not a feature, I updated your title to use the "fix" prefix instead of "feat". |
cameronwaterman
approved these changes
May 28, 2024
mure
pushed a commit
that referenced
this pull request
May 29, 2024
## [3.10.1](v3.10.0...v3.10.1) (2024-05-29) ### Bug Fixes * **notebook:** fix notebook plugin not loading notebook parameters when opening visualization ([#61](#61)) ([c81d963](c81d963))
|
🎉 This PR is included in version 3.10.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
The notebook parameters are not loading when reopening a visualisation from notebook plugin data source.
Steps to produce:
👩💻 Implementation
Use queried notebooks instead of notebooks from actual state. This is a problem because in the same function a state was both set and used. Here is a overview of how calls are made:
componentDidMount: setState, getNotebook, getNotebookMetadata (on retrieved notebook)
getNotebook: get notebook from saved state
Only after componentDidMount & getNotebook is finished the state is actually updated. So, because getNotebook actually called componentDidMount, the saved state there is actually the previous saved state, wich is null when the page loads.
This is a frequenctly bug in react. Here is a nice blog about it: link
🧪 Testing
N/A
✅ Checklist