feat(asset): add the query type and group by buttons for calibration forecast #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MileaRobertStefan
requested review from
CiprianAnton and
kkerezsi
as code owners
MileaRobertStefan
changed the title
kkerezsi
requested changes
Aug 20, 2024
OliverCosma
reviewed
Aug 20, 2024
CiprianAnton
approved these changes
Aug 20, 2024
OliverCosma
approved these changes
Aug 20, 2024
codrutaserban
approved these changes
Aug 20, 2024
kkerezsi
approved these changes
Aug 21, 2024
src/datasources/asset/components/AssetQueryCalibrationForecastEditor.tsx
Outdated
Show resolved
Hide resolved
src/datasources/asset/components/AssetQueryCalibrationForecastEditor.tsx
Show resolved
Hide resolved
src/datasources/asset/components/AssetQueryCalibrationForecastEditor.tsx
Outdated
Show resolved
Hide resolved
vpstoynova
reviewed
Aug 21, 2024
src/datasources/asset/components/AssetQueryCalibrationForecastEditor.tsx
Outdated
Show resolved
Hide resolved
vpstoynova
reviewed
Aug 21, 2024
…Editor.tsx Co-authored-by: vpstoynova <100705307+vpstoynova@users.noreply.github.com>
Co-authored-by: vpstoynova <100705307+vpstoynova@users.noreply.github.com>
MileaRobertStefan
changed the title
|
@cameronwaterman @mure I'm going to close this PR. If you find any issues please add a comment and I will address it in a different PR. |
mure
pushed a commit
that referenced
this pull request
Aug 28, 2024
## [3.12.0](v3.11.0...v3.12.0) (2024-08-28) ### Features * **asset:** add the query type and group by buttons for calibration forecast ([#64](#64)) ([7ab470b](7ab470b))
|
🎉 This PR is included in version 3.12.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
In the existing Grafana plugin for Assets , we want to implement a new query type for Calibration Forecast for Assets.
The Plugin will have the following fields when "Calibration Forecast" query type will be selected:
Query Configuration
Query Type
Group By
👩💻 Implementation
Add a radio button that allows to select the query type.
Add a multi select with custom logic to handle the selection of group by day / week / month.
🧪 Testing
Added new unit tests to cover the changes.
Backend call:
✅ Checklist