Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Service Principal Authentication methods #12

Merged
merged 14 commits into from
Apr 6, 2023

Conversation

davidcorrigan714
Copy link
Collaborator

@davidcorrigan714 davidcorrigan714 commented Apr 6, 2023

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Allows the terraform provider to authenticate to azure devops through a service principal using a variety of authentication methods: client secret, client certificate, GitHub Actions OIDC tokens, Terraform Cloud OIDC tokens, & any other OIDC token provided directly as an attribute

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Brings in the Azure Go SDK & some crypto libraries.

Does this introduce a breaking change?

  • Yes
  • No

Copy link
Collaborator

@irwand irwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the description has "No" checked on "brings in crypto library" but I think you are bringing crypto library, right?

@davidcorrigan714
Copy link
Collaborator Author

the description has "No" checked on "brings in crypto library" but I think you are bringing crypto library, right?

Whoops, missing a question header there from the template. Fixed to indicate no breaking changes.

@davidcorrigan714 davidcorrigan714 merged commit 132ac70 into ni-main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants