-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created service end point for NuGet #8
Created service end point for NuGet #8
Conversation
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_nuget.go
Outdated
Show resolved
Hide resolved
@davidcorrigan714 : Please review now. I believe that it is now completely ready to be submitted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove all references to that hashing & diff functions.
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_nuget.go
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_nuget.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_nuget.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_nuget.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_nuget.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_nuget.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_nuget.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_nuget.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_nuget.go
Outdated
Show resolved
Hide resolved
azuredevops/internal/service/serviceendpoint/resource_serviceendpoint_nuget.go
Show resolved
Hide resolved
…ndpoint_nuget.go Co-authored-by: David Corrigan <47994662+davidcorrigan714@users.noreply.github.com>
…ndpoint_nuget.go Co-authored-by: David Corrigan <47994662+davidcorrigan714@users.noreply.github.com>
…ndpoint_nuget.go Co-authored-by: David Corrigan <47994662+davidcorrigan714@users.noreply.github.com>
…ndpoint_nuget.go Co-authored-by: David Corrigan <47994662+davidcorrigan714@users.noreply.github.com>
…ndpoint_nuget.go Co-authored-by: David Corrigan <47994662+davidcorrigan714@users.noreply.github.com>
…ndpoint_nuget.go Co-authored-by: David Corrigan <47994662+davidcorrigan714@users.noreply.github.com>
…ndpoint_nuget.go Co-authored-by: David Corrigan <47994662+davidcorrigan714@users.noreply.github.com>
…ndpoint_nuget.go Co-authored-by: David Corrigan <47994662+davidcorrigan714@users.noreply.github.com>
…ndpoint_nuget.go Co-authored-by: David Corrigan <47994662+davidcorrigan714@users.noreply.github.com>
@davidcorrigan714 All requested changes addressed, Can you please help this PR get in, if fine? |
if strings.EqualFold(*serviceEndpoint.Authorization.Scheme, "UsernamePassword") { | ||
if _, ok := d.GetOk("authentication_basic"); !ok { | ||
auth := make(map[string]interface{}) | ||
auth["username"] = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, username should be read in this case. With the Artifactory ones it doesn't work because the username field got marked as sensitive in the AzDO service connection extension by accident. JFrog will fix that in their next extension release. For all practical purposes it doesn't matter, but may want to fix it for upstreaming. @innagarc
Description: "The Nuget feed user name.", | ||
Type: schema.TypeString, | ||
Required: true, | ||
Sensitive: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also probably shouldn't be sensitive if it's not in the service connection.
All Submissions:
What about the current behavior has changed?
Added the ability to create service connections for NuGet, supporting 3 types of authentication
Unit tests passing:
Acceptance tests passing:
Issue Number:
Does this introduce a change to
go.mod
,go.sum
orvendor/
?Does this introduce a breaking change?
Any relevant logs, error output, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Other information