fix: logical in ModelNegativeADTnorm.r #47
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
ModelNegativeADRnorm
there is a logical that will always return FALSE, and the corresponding if statement (dealing with the case when a model could not be fit for some markers) will thus never trigger. This PR fixes this.The issue comes from the use of
all.equal
, which will returnTRUE
if all elements across two vectors are equal, and a string if they are not. TheisFALSE
function would thus returnFALSE
whetherall.equal
returnsTRUE
or a string.Here is an example: