Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new IF czi workflow #299

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Adding new IF czi workflow #299

merged 3 commits into from
Sep 11, 2023

Conversation

philipmac
Copy link
Member

@philipmac philipmac commented Sep 8, 2023 •
edited by annshress
Loading

Addresses - #227

Changes

  • Adds workflow to convert czi image data
  • Workflow now uses pytools.HedwigZarrImage object for zarr manipulation
  • Breaking Change - the callback data structure ( the new structure has been merged conform to new callback format #274 and it will be reflected on this workflow callback)

This PR doesn't introduce any:

  • Binary files
  • Temporary files, auto-generated files
  • Secret keys
  • Local debugging print statements
  • Unwanted comments (e.g: # Gets user from environment for code os.environ['user'] )

This PR contains valid:

  • tests

annshress
annshress requested changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@annshress annshress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some minor comments. Apart from that it looks good!

em_workflows/czi/flow.py Outdated Show resolved Hide resolved
em_workflows/czi/flow.py Outdated Show resolved Hide resolved
em_workflows/czi/flow.py Outdated Show resolved Hide resolved
em_workflows/czi/flow.py Outdated Show resolved Hide resolved
annshress
annshress reviewed Sep 8, 2023
View reviewed changes
em_workflows/czi/flow.py Outdated Show resolved Hide resolved
@annshress annshress force-pushed the czi_to_zarr_wf branch 5 times, most recently from b8e18ea to 43500ab Compare September 11, 2023 18:49
@annshress annshress changed the title WIP Adding new IF czi workflow Adding new IF czi workflow Sep 11, 2023
@annshress annshress self-requested a review September 11, 2023 19:37
@philipmac philipmac merged commit 10e07c3 into main Sep 11, 2023
2 checks passed
@philipmac philipmac deleted the czi_to_zarr_wf branch September 11, 2023 19:41
@philipmac philipmac mentioned this pull request Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annshress annshress annshress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philipmac @annshress