Log and write subprocess output as produced. #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior implemenation would wait until the process had completed before producing any outputs to the file or to the log. This improvement reports the standard output and error as each line is being produced.
blowekamp
force-pushed
the
run_live_output
branch
from
0f4b664 to
6dde776
Compare
philipmac
reviewed
Nov 14, 2024
| @@ -92,7 +90,7 @@ def convert_if_int16_tiff(file_path: FilePath) -> None: | |||
| str(tif_8_bit), | |||
| ] | |||
| utils.log(f"Generated cmd {cmd}") | |||
| FilePath.run(cmd, log_fp) | |||
| FilePath.run(cmd, log_fp, env={"IMOD_OUTPUT_FORMAT": "TIF"}) | |||
There was a problem hiding this comment.
The important things added is the usage of pipes with streaming output so that the output of the process can be seen live or if the task is killed by slum the partial output would be there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior implemenation would wait until the process had completed before producing any outputs to the file or to the log. This improvement reports the standard output and error as each line is being produced.
Addresses (eg: #1)
Depends on (eg: #1)
Changes
This PR doesn't introduce any:
printstatementsos.environ['user'])This PR contains valid: