Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: CMP0077 is implied by cmake_minimum_required(VERSION 3.16) #238

Closed
wants to merge 1 commit into from

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Dec 19, 2024

No description provided.

@nibanks
Copy link
Owner

nibanks commented Dec 19, 2024

Can you please provide more description as to why this is necessary?

@dg0yt
Copy link
Contributor Author

dg0yt commented Dec 20, 2024

I realize that I overlooked the actual nature of this line: It does have an effect on the project commands in the subdirs, in particular for ls-qpack. Without that line, CMP0077 would might be unset after subdir project, regardless of the top-level choice.
(I tested this in a separate project now. CMake documentation didn't seem entirely clear.)

Nevertheless it might become obsolete in the future when the subprojects raise their minimum required version. And with modern versions of CMake, version lower than 3.10 are causing deprecation warnings.

@dg0yt dg0yt closed this Dec 20, 2024
@dg0yt dg0yt deleted the patch-1 branch December 20, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants