CMake: Enable configuration of CMAKE_BUILD_TYPE #239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msh3 used to hardcode the value of
CMAKE_BUILD_TYPE
toRelease
, in the middle ofCMakeLists.txt
. This is unexpected and a source of problems.CMAKE_BUILD_TYPE
is a variable which is meant to be controlled by the user. Also package managers like vcpkg make use of this as a general input variable.The natural way to implement defaults for user controlled variables is using cache variables.
This PR aligns msh3 with common practice: It sets a default early in
CMakeLists.txt
, as a cache variable subject to user control.