Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graphical Update for V 2.0 #50

Merged
merged 7 commits into from
Jul 8, 2020
Merged

Graphical Update for V 2.0 #50

merged 7 commits into from
Jul 8, 2020

Conversation

int5749
Copy link
Contributor

@int5749 int5749 commented Jul 7, 2020

  • Re-Structuring of Sitemap
  • Enhancement of visibility for Items in Sitemap according to Status
  • Transformation to Display Days-Hours-Minutes rather than Minutes only for Time Items

int5749 added 2 commits July 7, 2020 22:46
@int5749
Graphical Update
42edad2 
Graphical Update for V 2.0
@int5749
Update README.md
834194f
nibi79
nibi79 reviewed Jul 8, 2020
View reviewed changes
README.md Outdated
Comment on lines 291 to 292
Number LandroidId "Id []" {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgCommon#id"}
Number LandroidProductId "Id []" {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgCommon#id"}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1x removed

README.md Outdated
Number LandroidScheduleMondayStartMinutes "Start Minutes [%d]" <time> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgScMonday#scheduleStartMinutes"}
Number LandroidScheduleMondayDuration "Duration [%d]" <time> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgScMonday#scheduleDuration"}
Switch LandroidScheduleMondayEdgecut "Edgecut" <lawnmower> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgScMonday#scheduleEdgecut"}
Switch LandroidScheduleMondayEnable "Monday: [MAP(landroid_schedule_enable.map):%s]" <time> {channel="worxlandroid:mower:MyWorxBridge:30173502170118050389:cfgScMonday#enable",autoupdateautoupdate="false"}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Serial, autoupdateautoupdate (why)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy & replace issue => corrected

README.md Outdated
Number LandroidScheduleTuesdayStartMinutes "Start Minutes [%d]" <time> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgScTuesday#scheduleStartMinutes"}
Number LandroidScheduleTuesdayDuration "Duration [%d]" <time> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgScTuesday#scheduleDuration"}
Switch LandroidScheduleTuesdayEdgecut "Edgecut" <lawnmower> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgScTuesday#scheduleEdgecut"}
Switch LandroidScheduleTuesdayEnable "Tuesday: [MAP(landroid_schedule_enable.map):%s]" <time> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgScTuesday#enable",autoupdateautoupdate="false"}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoupdateautoupdate (why)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

README.md Outdated
Number LandroidScheduleWednesdayStartMinutes "Start Minutes [%d]" <time> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgScWednesday#scheduleStartMinutes"}
Number LandroidScheduleWednesdayDuration "Duration [%d]" <time> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgScWednesday#scheduleDuration"}
Switch LandroidScheduleWednesdayEdgecut "Edgecut" <lawnmower> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgScWednesday#scheduleEdgecut"}
Switch LandroidScheduleWednesdayEnable "Wednesday: [MAP(landroid_schedule_enable.map):%s]" <time> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgScWednesday#enable",autoupdateautoupdate="false"}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoupdateautoupdate (why)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

README.md Outdated
Number LandroidScheduleThursdayStartMinutes "Start Minutes [%d]" <time> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgScThursday#scheduleStartMinutes"}
Number LandroidScheduleThursdayDuration "Duration [%d]" <time> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgScThursday#scheduleDuration"}
Switch LandroidScheduleThursdayEdgecut "Edgecut" <lawnmower> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgScThursday#scheduleEdgecut"}
Switch LandroidScheduleThursdayEnable "Thursday: [MAP(landroid_schedule_enable.map):%s]" <time> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgScThursday#enable",autoupdateautoupdate="false"}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoupdateautoupdate (why)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

README.md Outdated
Number LandroidScheduleSaturdayStartMinutes "Start Minutes [%d]" <time> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgScSaturday#scheduleStartMinutes"}
Number LandroidScheduleSaturdayDuration "Duration [%d]" <time> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgScSaturday#scheduleDuration"}
Switch LandroidScheduleSaturdayEdgecut "Edgecut" <lawnmower> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgScSaturday#scheduleEdgecut"}
Switch LandroidScheduleSaturdayEnable "Saturday: [MAP(landroid_schedule_enable.map):%s]" <time> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgScSaturday#enable",autoupdateautoupdate="false"}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Serial, autoupdateautoupdate (why)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

README.md Outdated
Number LandroidAllocation7 "Alloction 7 []" <zones> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgMultiZones#allocation7"}
Number LandroidAllocation8 "Alloction 8 []" <zones> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgMultiZones#allocation8"}
Number LandroidAllocation9 "Alloction 9 []" <zones> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgMultiZones#allocation9"}
Switch LandroidScheduleSundayEnable "Sunday: [MAP(landroid_schedule_enable.map):%s]" <time> {channel="worxlandroid:mower:MyWorxBridge:MySerialNumber:cfgScSunday#enable",autoupdateautoupdate="false"}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Serial, autoupdateautoupdate (why)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last copy&replace => corrected

README.md Outdated
Group item=Shaun icon="landroid" {
Frame {
Switch item=LandroidEnable label="Mowing enabled"
Group item=Shaun icon="worx_landroid_logo.png" {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change icon

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

README.md Outdated
Comment on lines 538 to 624
4. [Landroid](/openhab-conf/icons/landroid.png)

4. [Worx-Logo](/openhab-conf/icons/worx_landroid_logo.png)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change icon back

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

README.md
}
```

### Preview of above Sitemap

<img src="images/SC_BasicUI_Main_Status.png" width="50%">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change icon

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new screenshot made => corrected

int5749 added 3 commits July 8, 2020 07:44
@int5749
Fix Logo
a3137b0 
Fixed Logo and minor Language issues
@int5749
Update README.md
8ec86c5
@int5749
Update README.md
6ce3799
@int5749
Copy link
Contributor Author

int5749 commented Jul 8, 2020

All above corrected in next Pull Request

@nibi79 nibi79 merged commit 30998e6 into nibi79:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nibi79 nibi79 nibi79 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@int5749 @nibi79