Use Vec::as_mut_ptr to obtain a buffer for __system_property_get. #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the idiom recommended by the Nomicon for allocating a buffer into which C code will write data:
https://doc.rust-lang.org/nomicon/ffi.html#creating-a-safe-interface
The current code is almost certainly fine in practice, but it doesn't follow the letter of the law. The documentation for
CString::into_raw
says:https://doc.rust-lang.org/std/ffi/struct.CString.html#method.into_raw