You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A lot of crates depending on this crate probably won't use dump_svg or dump_into_svg, so it would be great if we could remove this dependency by default and still have a way to opt-in (e.g. with a svg feature or similar).
I'd be happy to PR this if that sounds good.
The text was updated successfully, but these errors were encountered:
grovesNL
added a commit
to grovesNL/etagere
that referenced
this issue
Apr 19, 2022
Hi, sorry for the delay I've been away from computers for a couple of weeks.
svg_fmt is a very tiny dependency, it should not affect build times significantly and since there's no polymorphism at play the compiler has a very easy time not inculding the dumping code into the binary if it isn't used.
Unless you have evidence that build times or release binary sizes are noticeably affected I would prefer to keep it without feature gate for simplicity's sake.
I'm targeting WebAssembly, so the concern is mostly about binary size and generally avoiding any extra dependencies. I'll check whether it's included into the final binary – maybe it's already being eliminated during build/linking like you mentioned.
A lot of crates depending on this crate probably won't use
dump_svg
ordump_into_svg
, so it would be great if we could remove this dependency by default and still have a way to opt-in (e.g. with asvg
feature or similar).I'd be happy to PR this if that sounds good.
The text was updated successfully, but these errors were encountered: