Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement bevel line joins #166

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Implement bevel line joins #166

merged 1 commit into from
Sep 11, 2017

Conversation

dd10-e
Copy link
Contributor

@dd10-e dd10-e commented Sep 9, 2017

#34
As you see, all works :
yeah

but, when i press "z", we can see that :
noooo

It's the same bug that Round join have. I will take some times for see what doesen't work. It's something related to sides i think.

@nical
Copy link
Owner

nical commented Sep 11, 2017

Looks good! the reason the rendering looks off when you press 'z' a lot is that the line width becomes negative and the shader starts pushing vertices in the opposite direction. This is not related to your bevel implementation, it's really just the demo which should prevent the width from being negative since it makes no sense.

Could you squash the three commits into one commit? After that we are good to merge.

Fix broken links in lyon_tessellation doc

Fix tests

Fix
@dd10-e
Copy link
Contributor Author

dd10-e commented Sep 11, 2017

Done! Also it will resolve this issue #165 normally.
Thanx for your explanations!

@nical nical merged commit fb751f5 into nical:master Sep 11, 2017
@nical
Copy link
Owner

nical commented Sep 11, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants