-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no_std
support for lyon_tessellation
#887
Conversation
I've noticed through testing that the final remaining blocker on A possible alternative would be to use a different error handling (eg: Snafu) that is behind an optional I haven't spent enough time looking I'd be very interested in making this crate |
Having read a bit more into this, I've successfully gotten The two big changes were:
I'd love to see this merged, so please let me know if there's anything that needs fixing, thanks! |
Hi, thanks for this PR, I haven't had time to look at it yet but I hope to get to it soon. |
Looks good, thanks! |
Thanks! You may have noticed but with this change the entire |
I hadn't noticed! I'm planning to add a fair amount of stuff in lyon's meta crate so let's not mark it as no_std compatible now since I don't know that it can remain that way later. For lyon_algorithm, you are welcome to make the change if you want to, but it's also fine to wait and see if anyone needs it (and submits a PR for it). |
lyon_tessellation
rigid dependency on default features fromlyon_path
std
, enabled by default, which enablesstd
feature oflyon_path
dependencystd
with their corresponding imports fromalloc
andcore
std
to display printed debug assertions#[cfg(test)]
to be explicit about their dependence onstd