-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failures with icalendar 5.0.9 #8
Comments
12 tasks
Thanks for reporting this! I wonder what caused the breakage. I think that maybe the tests need adjusting a little but actually, the functionality is still intact. python-recurring-ical-events would fail otherwise. It is good to look into it and port the CI to Github Actions to catch these kinds of errors.
What are your thoughts?
|
Some tests still fail:
|
Thanks for working on it. That is better. I think that a PR to fix this might have a version of icalendar above a certain version in the requirements. I wonder which element makes it fail.
|
I am opening it again until the tests pass. #9 makes an attempt. |
dotlambda
added a commit
to dotlambda/nixpkgs
that referenced
this issue
Nov 1, 2023
According to niccokunzmann/x-wr-timezone#8 the functionality is still intact despite the test failures.
Merged
@dotlambda, #9 makes the test intact again. The icalendar update helped compare the calendars and find a bug. I will close this for now. Feel free to open it again if you have any doubts! |
The fix is live as v0.0.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We're using Polar.sh so you can upvote and help fund this issue. We receive the funding once the issue is completed & confirmed by you. Thank you in advance for helping prioritize & fund our work.
The text was updated successfully, but these errors were encountered: