Fix bad frames detection in stats plugin for python3

src/eyed3/plugins/stats.py

@@ -27,7 +27,7 @@
 from eyed3.utils import guessMimetype
 from eyed3.utils.console import Fore, Style, printMsg
 from eyed3.plugins import LoaderPlugin
-from eyed3.id3.frames import ImageFrame
+from eyed3.id3 import frames
 
 ID3_VERSIONS = [id3.ID3_V1_0, id3.ID3_V1_1,
                 id3.ID3_V2_2, id3.ID3_V2_3, id3.ID3_V2_4]
@@ -150,7 +150,7 @@ def test(self, path, audio_file):
         return None
 
 
-BAD_FRAMES = ["PRIV", "GEOB"]
+BAD_FRAMES = [frames.PRIVATE_FID, frames.OBJECT_FID]
 
 
 class Id3FrameRules(Rule):
@@ -162,9 +162,10 @@ def test(self, path, audio_file):
         tag = audio_file.tag
         for fid in tag.frame_set:
             if fid[0] == 'T' and fid != "TXXX" and len(tag.frame_set[fid]) > 1:
-                scores.append((-10, "Multiple %s frames" % fid))
+                scores.append((-10, "Multiple %s frames" % fid.decode('ascii')))
             elif fid in BAD_FRAMES:
-                scores.append((-13, "%s frames are bad, mmmkay?" % fid))
+                scores.append((-13, "%s frames are bad, mmmkay?" %
+                               fid.decode('ascii')))
 
         return scores
 
@@ -381,8 +382,8 @@ def __init__(self):
         super(Id3ImageTypeCounter, self).__init__()
 
         self._key_names = {}
-        for attr in dir(ImageFrame):
-            val = getattr(ImageFrame, attr)
+        for attr in dir(frames.ImageFrame):
+            val = getattr(frames.ImageFrame, attr)
             if isinstance(val, int) and not attr.endswith("_TYPE"):
                 self._key_names[val] = attr
 

src/test/test_stats_plugins.py

@@ -0,0 +1,32 @@
+from __future__ import unicode_literals
+import os
+import tempfile
+import unittest
+
+import eyed3.id3
+import eyed3.main
+
+from . import RedirectStdStreams
+
+
+class TestId3FrameRules(unittest.TestCase):
+    def test_bad_frames(self):
+        try:
+            fd, tempf = tempfile.mkstemp(suffix='.id3')
+            os.close(fd)
+            tagfile = eyed3.id3.TagFile(tempf)
+            tagfile.initTag()
+            tagfile.tag.title = 'mytitle'
+            tagfile.tag.privates.set(b'mydata', b'onwer0')
+            tagfile.tag.save()
+            args = ['--plugin', 'stats', tempf]
+            args, _, config = eyed3.main.parseCommandLine(args)
+
+            with RedirectStdStreams() as out:
+                eyed3.main.main(args, config)
+        finally:
+            os.remove(tempf)
+
+        print(out.stdout.getvalue())
+
+        self.assertIn('PRIV frames are bad', out.stdout.getvalue())