Try to unbreak Py3.12 by giving the current_py_cc_libs to the nanobin…

…d_extension
nicholasjng · Mar 22, 2024 · 35d12a9 · 35d12a9
1 parent 68dbfd8
commit 35d12a9
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/build_defs.bzl b/build_defs.bzl
@@ -26,7 +26,12 @@ NANOBIND_FEATURES = [
 NANOBIND_DEPS = [
     Label("@nanobind"),
     "@rules_python//python/cc:current_py_cc_headers",
-]
+] + select({
+    # we need to link in the Python libs only on Windows to signal to the linker that it
+    # needs to go searching for these symbols at runtime.
+    "@rules_cc//cc/compiler:msvc-cl": ["@rules_python//python/cc:current_py_cc_libs"],
+    "//conditions:default": [],
+})
 
 # A C++ Python extension library built with nanobind.
 # Given a name $NAME, defines the following targets: