Add generalized benchmark IO, refactor console reporting, harmonize pybm env interface
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds two major features: 1) `pybm env switch` is now exposed as a command line option to switch checkouts of environments. 2) The benchmark results are now handled by the reporter, who gets a new IO class member responsible for reading and writing benchmark results. On top of this, the `pybm env install/uninstall` commands are now also piped through to the environment store, so that `pybm env` is now a legitimate thin shim around the EnvironmentStore class.
…vBuilder Changelist: * requirements_file is now a supported argument on the VenvBuilder * The `get_filenames`, `lsdir` APIs were introduced, acting as directory discovery methods. * A bug in the `partition_n` utility was fixed which would result in list duplication.
This commit adds a generalized IO component for pybm, which allows to save benchmark results obtained from subprocesses in different ways. As a first IO class, the JSONFileIO was added, which reads and writes JSON files locally to/from disk. The ConsoleReporter was greatly simplified as a result. The main benchmark result processing logic is now much shorter and more concise. Formatting, reducing and comparing was moved to external APIs specific to the ConsoleReporter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37. Fixes #35.