Allows manifest.json to be gzip compressed #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasyager
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
@alangner This PR absolutely rocks. I confirmed that this is working as expected for both S3 and Azure, and the implementation looks solid. Thank you for contributing -- this will be wildly useful!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to use gzip compressed manifest.json files with dbt-loom.
Compressed files are recognized based on the file extension (.gz).
I have only tested it for GCS and local files as this is what I am currently using, but I implemented the logic also for S3 and Azure storage for completeness.