-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Node 20 #126
Upgrade to Node 20 #126
Conversation
This looks great 🙌🏼 I also noticed all the warnings and it's nice to see this PR 💚 It looks like there is nothing else to do in this PR, right? |
@Jolg42 I'm not actually sure how to vet my changes here. The |
On your fork, I guess Actions are not enabled because there is no run here: The easiest would be to have them running here for this PR, I think the GitHub Actions workflow is waiting from the approval from a maintainer to run now. |
Actions are now enabled in my repo, and I have attempted to fix the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the submission!
Tests passed, releasing now |
Replace the bullet points below with your answers
Description
Resolves #125
More info here: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
Without migrating from
@zeit/ncc
to@vercel/ncc
I got the following, I think due to OpenSSL / Node version mismatch:Testing