-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile error in Node V12.* #206
Comments
thanks for the report @alkan . Can you provide the full error logs? Otherwise the report provided just looks like Also, how did you invoke the build? |
Use Vue-Cli install nanomsg4.0.2 .My nodejs version is v12.0.0
|
There are 2 errors in @enjoy05sky 's report:
I don't understand how either of the two would fail to compile, and just on windows, unless the version of nan we're using has known issues (just on Windows in nodejs v12) or changed somehow. Looks like we're using nan 2.8. Line 8 in 60de923
Most recent version is 2.14. https://www.npmjs.com/package/nan We could probably try to upgrade our version of nan. Ah, looking at nan's issue tracker, nodejs/nan#849 (comment) references the above. Also, this likely slipped passed us because the latest version of nodejs in our issue tracker is v9 (so we haven't been testing v12): https://github.com/nickdesaulniers/node-nanomsg/blob/master/.travis.yml |
Indeed, I just install node 12.5 and can repro on Linux, so this has nothing to do Windows specifically. |
- upgrade nan to v2.14 - use Nan::Utf8String rather than v8::String::Utf8Value Fixes #206
* support node v12 - upgrade nan to v2.14 - use Nan::Utf8String rather than v8::String::Utf8Value Fixes #206 * fix 1 of the 2 Nan::Callback::Call deprecation warnings Looks like the Nan::Callback::Call() API deprecated bare calls that don't pass a new Nan::AsyncResource(). Luckily, in this case we were already subclassing Nan::AsyncWorker, which has a member named `async_resource` so all we have to do is explicitly pass this along. I wonder if Nan should just do this for me? *hmm* Bug #209
we still need to publish a version with the fix |
done! we just cut |
We get the following error while installing the package>
gyp ERR! build error gyp ERR! stack Error:
makefailed with exit code: 2 gyp ERR! stack at ChildProcess.onExit (/home/ayhan/devtools/node-12.4.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23) gyp ERR! stack at ChildProcess.emit (events.js:200:13) gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12) gyp ERR! System Linux 4.15.0-52-generic gyp ERR! command "/home/ayhan/devtools/node-12.4.0/bin/node" "/home/ayhan/devtools/node-12.4.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild" gyp ERR! cwd /home/ayhan/projects/matriks/dev/work/nnw/node_modules/nanomsg gyp ERR! node -v v12.4.0 gyp ERR! node-gyp -v v3.8.0 gyp ERR! not ok n
The text was updated successfully, but these errors were encountered: