buffer error: kMaxLength #47
Labels
Comments
|
its on current master, and it's not a timeout, but scroll up to the results on to see survey.js after you get: total ........................... 806/806
ok |
|
|
dont see the assertion error on node 10.. using osx yosemite. still linux assertion error is different, points at linux: ok survey.js ........................ 0/0
TAP version 13
node: ../src/node_buffer.cc:121: v8::Local<v8::Object> node::Buffer::New(node::Environment*, size_t): Assertion `(length) <= (kMaxLength)' failed.is btw running from commit c476019 |
|
If I upgrade to node v0.12.0 from v0.10.26 I see this. |
|
I wonder where |
|
Also, I bet we shouldn't be using uint32's somewhere: |
|
I should be able to run that one test individually with |
|
It's definitely this line that is triggering it: Line 134 in 1620d3b |
|
it fails because node-nanomsg/src/node_nanomsg.cc Line 198 in 0ffb39f |
reqshark
added a commit
that referenced
this issue
Feb 20, 2015
fixes #47 with a necessary check removed in c0336f19cd6376607 31f32911d1f31b09e6f7f8f • if nn_recv() errors setting len to -1, node buffer library will accordingly refuse to allocate (malloc or smalloc) an impossible size in memory
|
fixed c50541c |
|
@nickdesaulniers good catch! |
reqshark
added a commit
that referenced
this issue
Feb 24, 2015
sockopt API • convenience methods for `get/setsockopt()` an interface to nanomsg socket options by way of: `socket.option(param)` or `socket.option()` passing a param sets that, while no param gets that. *a few caveats will be referenced in forthcoming docs it’s the simple interface i wrote in nanomsg.iojs covering: • tcpnodelay • linger • sndbuf • rcvbuf • sndtimeo • rcvtimeo • reconn • maxreconn • sndprio • rcvprio test: socket.tcpnodelay(boolean) document the api opts initializer also added some semicolons add note on address strings act like a getter, not a setter delete var domain test: sockoptapi.js semicolons docs: update raw opt use more nn.Err() remove nn.Strerr() C++ function, use nn.Err() maintain byte length check during nn_recv() operation fixes #47 with a necessary check removed in c0336f19cd6376607 31f32911d1f31b09e6f7f8f • if nn_recv() errors setting len to -1, node buffer library will accordingly refuse to allocate (malloc or smalloc) an impossible size in memory test: set sockopts when starting the socket unorthodox symbol fix: rvcprio() opval dry it out a bit docs: rcvbuf and sndbuf unit is size in bytes adding Makefile after pulling down run git submodule update - -init: when building the repo on unix for node/iojs versions just go: nvm use $VERSION && make full make full removes the build and node_modules directory first then it rebuilds the project compiling sources then it runs the test suite. if you only want to rebuild for a different version just go: make clean && make we’ll probably want to uncomment the perf stuff once that’s setup docs: the Makefile docs: move contributing under test section js: put sockopt API methods onto Socket prototype js: line up the o's (ocd) docs: also add size in bytes to top links js: partial function application & test: RCVPRIO • adds TODO: Issue #50 comment on line 19 • rewrite opts check for RAW & remove redundant error check - RAW option now more consistent with its description in docs • partial function application: tighten up opts API methods • test: RCVPRIO, ensure symbol test fails for the missing symbol js: clean up, opt function context minor bump bump version
reqshark
added a commit
that referenced
this issue
Feb 24, 2015
• convenience methods for `get/setsockopt()`, an interface to nanomsg socket options by way of: `socket.option(param)` or `socket.option()` passing a param sets that, while no param gets that. it’s the simple interface i wrote in nanomsg.iojs covering: - tcpnodelay - linger - sndbuf - rcvbuf - sndtimeo - rcvtimeo - reconn - maxreconn - sndprio - rcvprio • adds documentation • fixes #47 with a necessary check removed in c0336f1 • if nn_recv() errors setting len to -1, node buffer library will accordingly refuse to allocate (malloc or smalloc) an impossible size in memory • test: set sockopts when starting the socket • unorthodox symbol fix: rvcprio() • the Makefile • adds TODO: Issue #50 comment on line 19 • rewrite opts check for RAW & remove redundant error check - RAW option now more consistent with its description in docs • partial function application: tighten up opts API methods • test: RCVPRIO, ensure symbol test fails for the missing symbol • bump version
reqshark
added a commit
that referenced
this issue
Feb 24, 2015
• convenience methods for `get/setsockopt()`, an interface to nanomsg socket options by way of: `socket.option(param)` or `socket.option()` passing a param sets that, while no param gets that. it’s the simple interface i wrote in nanomsg.iojs covering: - tcpnodelay - linger - sndbuf - rcvbuf - sndtimeo - rcvtimeo - reconn - maxreconn - sndprio - rcvprio • adds documentation • fixes #47 with a necessary check removed in c0336f1 • if nn_recv() errors setting len to -1, node buffer library will accordingly refuse to allocate (malloc or smalloc) an impossible size in memory • test: set sockopts when starting the socket • unorthodox symbol fix: rvcprio() • the Makefile • adds TODO: Issue #50 comment on line 19 • rewrite opts check for RAW & remove redundant error check - RAW option now more consistent with its description in docs • partial function application: tighten up opts API methods • test: RCVPRIO, ensure symbol test fails for the missing symbol • bump version PR: #46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
running the test suite on osx and linux i get a buffer triggered assertion crap out on
survey.js.also wondering why tape is zero for zero when
t.plan(4):The text was updated successfully, but these errors were encountered: