Skip to content

Commit

Permalink
Merge pull request akira#111 from akira/redis_test_cleanup
Browse files Browse the repository at this point in the history
Cleanup Redis startup/shutdown in tests
  • Loading branch information
akira committed Nov 7, 2015
2 parents 6e90755 + 3db252b commit 79fd048
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 6 deletions.
1 change: 1 addition & 0 deletions test/config_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ defmodule Exq.ConfigTest do

setup_all do
ExqTestUtil.reset_config
:ok
end

test "Mix.Config should change the host." do
Expand Down
4 changes: 2 additions & 2 deletions test/exq_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ defmodule ExqTest do
{:ok, sup} = Exq.start_link([name: :exq_t, host: redis_host, port: redis_port, namespace: "test", queues: [{"q1", 1}, {"q2", 20}]])
{:ok, _} = Exq.enqueue(:exq_t, "q1", ExqTest.SleepWorker, [40, :worked])
{:ok, _} = Exq.enqueue(:exq_t, "q1", ExqTest.SleepWorker, [40, :worked2])
{:ok, _} = Exq.enqueue(:exq_t, "q1", ExqTest.SleepWorker, [100, :finished])
{:ok, _} = Exq.enqueue(:exq_t, "q1", ExqTest.SleepWorker, [100, :should_not_finish])
# q2 should be clear
{:ok, _} = Exq.enqueue(:exq_t, "q2", ExqTest.SleepWorker, [100, :q2_work])
{:ok, _} = Exq.enqueue(:exq_t, "q2", ExqTest.SleepWorker, [100, :q2_work])
Expand All @@ -176,7 +176,7 @@ defmodule ExqTest do

assert_received {"worked"}
assert_received {"worked2"}
refute_received {"finished"}
refute_received {"should_not_finish"}
assert_received {"q2_finished"}
stop_process(sup)
end
Expand Down
14 changes: 10 additions & 4 deletions test/test_helper.exs
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,14 @@ defmodule TestRedis do
end

def setup do
start
{:ok, redis} = :eredis.start_link(redis_host, redis_port)
Process.register(redis, :testredis)
flush_all
:ok
end

def flush_all do
Connection.flushdb! :testredis
Connection.flushdb! :testredis
end

def teardown do
Expand All @@ -99,17 +99,23 @@ defmodule TestRedis do
{:ok, redis} = :eredis.start_link(redis_host, redis_port)
Process.register(redis, :testredis)
end
flush_all
stop
Process.unregister(:testredis)
:ok
end
end



# Don't run parallel tests to prevent redis issues
ExUnit.configure(seed: 0, max_cases: 1)

# Start logger
:application.start(:logger)

TestRedis.start

System.at_exit fn(status) ->
TestRedis.stop
end

ExUnit.start

0 comments on commit 79fd048

Please sign in to comment.