Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency request version #149

Closed
taoyuan opened this issue Dec 21, 2016 · 2 comments
Closed

Update dependency request version #149

taoyuan opened this issue Dec 21, 2016 · 2 comments

Comments

@taoyuan
Copy link

taoyuan commented Dec 21, 2016

request@2.75.0 using node-uuid, but it has been deprecated.

Please update request to 2.79.1 to supress the warning.

Maybe we cloud upgrade all dependencies to latest version.
@OmgImAlexis OmgImAlexis mentioned this issue Jan 1, 2017
Closed
@ndaidong ndaidong mentioned this issue Jan 10, 2017
Merged
@revelt revelt mentioned this issue Jan 22, 2017
Closed
@SebastienElet SebastienElet mentioned this issue Feb 6, 2017
Merged
@OmgImAlexis
Copy link

Any updates on this? This has been open for 5 months now. 😞

@dogboydog
Copy link

dogboydog commented Sep 21, 2017 •
edited
Loading

Another reason to do this: the version of request used uses a vulernable tough-cookie dependency

https://nodesecurity.io/advisories/525

New version is available after this PR closed (salesforce/tough-cookie#92). Please update so nsp check and other security tools can succeed without adding exceptions

mdlavin added a commit to mdlavin/node-coveralls that referenced this issue Sep 28, 2017
@mdlavin
Expand allowed dependency versions to all API compatible versions
c2cd266 
Fixes nickmerwin#171
Fixes nickmerwin#170
Fixes nickmerwin#153
Fixes nickmerwin#149
Fixes nickmerwin#133
@mdlavin mdlavin mentioned this issue Sep 28, 2017
Merged
nickmerwin pushed a commit that referenced this issue Sep 28, 2017
@mdlavin @nickmerwin
Expand allowed dependency versions to all API compatible versions (#172)
428780c 
Fixes #171
Fixes #170
Fixes #153
Fixes #149
Fixes #133
@fguitton fguitton mentioned this issue Oct 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@taoyuan @OmgImAlexis @dogboydog