Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #284

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Update dependencies #284

merged 1 commit into from
Apr 23, 2020

Conversation

XhmikosR
Copy link
Contributor

@nickmerwin I kept the patches as separate commits just to be safe 🙂

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Apr 23, 2020

Weird that this fails here, it passes on my fork https://github.com/XhmikosR/node-coveralls/actions/runs/85991883

@XhmikosR
Copy link
Contributor Author

So, for some weird reason, when updating should to v13.2.3 tests fail here but not on my fork 😖

It would be nice if we could update should too at some point, but it's low priority.

@nickmerwin nickmerwin merged commit 59a57e2 into nickmerwin:master Apr 23, 2020
@nickmerwin
Copy link
Owner

@XhmikosR looking green now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants