fix(task-item): fix read only checked handling

Fixes ueberdosis#3676
nicksellen · Dec 21, 2024 · 4956ca9 · 4956ca9
1 parent d735cf3
commit 4956ca9
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/packages/extension-task-item/src/task-item.ts b/packages/extension-task-item/src/task-item.ts
@@ -149,7 +149,7 @@ export const TaskItem = Node.create<TaskItemOptions>({
 
         const { checked } = event.target as any
 
-        if (editor.isEditable && typeof getPos === 'function') {
+        if (typeof getPos === 'function') {
           editor
             .chain()
             .focus(undefined, { scrollIntoView: false })
@@ -161,6 +161,14 @@ export const TaskItem = Node.create<TaskItemOptions>({
               }
               const currentNode = tr.doc.nodeAt(position)
 
+              if (!editor.isEditable && this.options.onReadOnlyChecked) {
+                // Reset state if onReadOnlyChecked returns false
+                if (!this.options.onReadOnlyChecked(currentNode, checked)) {
+                  checkbox.checked = !checkbox.checked
+                  return false
+                }
+              }
+
               tr.setNodeMarkup(position, undefined, {
                 ...currentNode?.attrs,
                 checked,
@@ -170,12 +178,6 @@ export const TaskItem = Node.create<TaskItemOptions>({
             })
             .run()
         }
-        if (!editor.isEditable && this.options.onReadOnlyChecked) {
-          // Reset state if onReadOnlyChecked returns false
-          if (!this.options.onReadOnlyChecked(node, checked)) {
-            checkbox.checked = !checkbox.checked
-          }
-        }
       })
 
       Object.entries(this.options.HTMLAttributes).forEach(([key, value]) => {