Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test to new error message in go 1.16 #260

Merged
merged 2 commits into from
Jun 23, 2021

Conversation

jawn-smith
Copy link
Contributor

As of go 1.16, the error message in text/template for this specific case has changed.

@jawn-smith jawn-smith closed this Jun 23, 2021
@jawn-smith jawn-smith reopened this Jun 23, 2021
@jawn-smith
Copy link
Contributor Author

This latest commit addresses issue #259 by checking for a substring that is present in both go 1.15 and go 1.16.

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #260 (2c2ba6f) into main (482713a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #260   +/-   ##
=======================================
  Coverage   82.68%   82.68%           
=======================================
  Files          14       14           
  Lines        1178     1178           
=======================================
  Hits          974      974           
  Misses        141      141           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 482713a...2c2ba6f. Read the comment docs.

@nicksnyder nicksnyder merged commit dadad2b into nicksnyder:main Jun 23, 2021
@nicksnyder
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants