Skip to content

Commit

Permalink
feat(lib): support for angular v7 (#114)
Browse files Browse the repository at this point in the history
* feat(wip): upgrade dependencies to angular v7

* feat: move ngx-scroll-to module to angular v7 project

* feat: add stuff to package.json

* feat: add contributor 👍

* refactor: update package.json

* fix: remove e2e for now

* refactor: set default project to demo

* fix: lib test
  • Loading branch information
Nicky Lenaers authored Dec 12, 2018
1 parent 62baea0 commit 5b9cb85
Show file tree
Hide file tree
Showing 44 changed files with 5,082 additions and 7,668 deletions.
20 changes: 1 addition & 19 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,22 +68,7 @@ jobs:
- *restore_npm_cache_peer
- run:
name: Test Spec
command: npm run test -- --single-run=true --progress=false --code-coverage --log-level=DEBUG
- store_artifacts:
path: coverage/ts
destination: coverage
test_e2e:
<<: *job_defaults_browsers
steps:
- checkout
- *restore_npm_cache
- *restore_npm_cache_peer
- *update_chrome_driver
- run:
name: Test End to End
command: npm run ng:e2e
- store_test_results:
path: reports/e2e
command: npm run lib:test
lint:
<<: *job_defaults
steps:
Expand All @@ -103,9 +88,6 @@ workflows:
- test_spec:
requires:
- build
- test_e2e:
requires:
- build
- lint:
requires:
- build
5 changes: 5 additions & 0 deletions .huskyrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"hooks": {
"commit-msg": "commitlint --env HUSKY_GIT_PARAMS --extends \"@commitlint/config-angular\""
}
}
41 changes: 38 additions & 3 deletions angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": 1,
"newProjectRoot": "projects",
"projects": {
"ngx-scroll-to": {
"ngx-scroll-to-demo": {
"root": "",
"sourceRoot": "src",
"projectType": "application",
Expand Down Expand Up @@ -102,7 +102,7 @@
"builder": "@angular-devkit/build-angular:protractor",
"options": {
"protractorConfig": "e2e/protractor.conf.js",
"devServerTarget": "ngx-scroll-to:serve"
"devServerTarget": "ngx-scroll-to-demo:serve"
}
},
"lint": {
Expand All @@ -115,7 +115,42 @@
}
}
}
},
"ngx-scroll-to": {
"root": "projects/ngx-scroll-to",
"sourceRoot": "projects/ngx-scroll-to/src",
"projectType": "library",
"prefix": "lib",
"architect": {
"build": {
"builder": "@angular-devkit/build-ng-packagr:build",
"options": {
"tsConfig": "projects/ngx-scroll-to/tsconfig.lib.json",
"project": "projects/ngx-scroll-to/ng-package.json"
}
},
"test": {
"builder": "@angular-devkit/build-angular:karma",
"options": {
"main": "projects/ngx-scroll-to/src/test.ts",
"tsConfig": "projects/ngx-scroll-to/tsconfig.spec.json",
"karmaConfig": "projects/ngx-scroll-to/karma.conf.js"
}
},
"lint": {
"builder": "@angular-devkit/build-angular:tslint",
"options": {
"tsConfig": [
"projects/ngx-scroll-to/tsconfig.lib.json",
"projects/ngx-scroll-to/tsconfig.spec.json"
],
"exclude": [
"**/node_modules/**"
]
}
}
}
}
},
"defaultProject": "ngx-scroll-to"
"defaultProject": "ngx-scroll-to-demo"
}
6 changes: 0 additions & 6 deletions ng-package.json

This file was deleted.

Loading

0 comments on commit 5b9cb85

Please sign in to comment.