Ignore ill-formed trace events #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was using this tool against time traces generated in LLVM. The tool picked up a non-trace JSON file (tools/clang/lib/Tooling/ASTNodeAPI.json, in case you wonder) and bailed out with an exception. This patch fixes this issue by checking the format of the trace event JSON to make sure it has the 'traceEvents' field before moving on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using this tool against time traces generated in LLVM. The tool picked up a non-trace JSON file
(tools/clang/lib/Tooling/ASTNodeAPI.json, in case you wonder) and bailed out with an exception.
This patch fixes this issue by checking the format of the trace event JSON to make sure it has the 'traceEvents' field before moving on.