Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use engine.io #32

Open
nicobarray opened this issue May 7, 2018 · 1 comment
Open

Use engine.io #32

nicobarray opened this issue May 7, 2018 · 1 comment
Assignees
Labels
aquedux-client Any aquedux-client ONLY related issue aquedux-server Any aquedux-server ONLY related issues
Milestone

Comments

@nicobarray
Copy link
Owner

We should use engine.io for aquedux-server if their heartbeat behaviour match our needs.

@nicobarray nicobarray added the aquedux-client Any aquedux-client ONLY related issue label May 7, 2018
@nicobarray nicobarray added aquedux-server Any aquedux-server ONLY related issues and removed aquedux-client Any aquedux-client ONLY related issue labels May 7, 2018
@chabou chabou added the aquedux-client Any aquedux-client ONLY related issue label May 7, 2018
@chabou
Copy link
Collaborator

chabou commented May 7, 2018

Apparently, we can hook add a handler onheartbeat with SockJS.
This is how Meteor uses it:
meteor/meteor@a1a6414

Current stable sockjs protocol is 3.3.3. Features explained for 0.4.X are not yet implemented : sockjs/sockjs-client#67
https://github.com/sockjs/sockjs-protocol/wiki/Heartbeats-and-SockJS

If it doesn't work as expected, we can temporarily use https://github.com/primus/primus to have some keepalive and reconnection out of the box.

@nicobarray nicobarray mentioned this issue May 25, 2018
3 tasks
@nicobarray nicobarray added this to the 3.0.0 milestone May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aquedux-client Any aquedux-client ONLY related issue aquedux-server Any aquedux-server ONLY related issues
Projects
None yet
Development

No branches or pull requests

2 participants