Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally expect heartbeats from the server #67

Closed
majek opened this issue May 14, 2012 · 9 comments
Closed

Optionally expect heartbeats from the server #67

majek opened this issue May 14, 2012 · 9 comments

Comments

@majek
Copy link
Member

majek commented May 14, 2012

The server may send an option telling the client how often it will send 'heartbeat' frames.

We should read this option and, indeed, expect heartbeats. We should kill the session on a heartbeat miss.

majek added a commit that referenced this issue May 18, 2012
majek added a commit to sockjs/sockjs-node that referenced this issue May 18, 2012
majek added a commit to sockjs/sockjs-node that referenced this issue May 18, 2012
majek added a commit that referenced this issue May 22, 2012
majek added a commit that referenced this issue May 29, 2012
majek added a commit that referenced this issue May 29, 2012
majek added a commit that referenced this issue Jun 1, 2012
majek added a commit that referenced this issue Jun 6, 2012
majek added a commit that referenced this issue Jun 6, 2012
@glasser
Copy link
Contributor

glasser commented Sep 26, 2012

There was a lot of activity on this issue but it's still open. Does the feature work (and it should be closed)?

@hyperthunk
Copy link

@glasser I'm not 100% sure, but I'll discuss with @majek when I get a chance and either merge or close it.

@mokesmokes
Copy link

Any update?

@triopter
Copy link

It looks like all of this was on a "dev" branch that never got merged. Is there any plan to merge this into master and release it?

@majek
Copy link
Member Author

majek commented Feb 25, 2014

The fix was way harder then anticipated and required major changes to the codebase, and eventually I gave up. Sorry.

@3rd-Eden
Copy link

If you use primus on top of sockjs it will send these heartbeat packages for you. From client -> server and the server will automatically disconnect if a heartbeat missing/timed out. See https://github.com/primus/primus#heartbeats-and-latency

So if you really, this might be a viable option.

@triopter
Copy link

@majek that's too bad! We're testing out the "dev" branch with the heartbeats right now (it seems to be up to date w/ v0.3.4) and it appears to be working.

@3rd-Eden Thanks for the pointer to Primus -- we'll definitely take a look at that!

@rikoe
Copy link

rikoe commented Mar 7, 2017

Hi. This issue has been open for almost 5 years now. It was recently discussed in #297. Is there any plan to implement this feature? The client not being aware of the server disappearing from the network seems to be a major flaw.

What is the "dev" branch mentioned above that has never been merged if one wants to take a look at it?

@harshakakumanu
Copy link

Are there any plans in implementing this issue? Is there any work around ?

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

9 participants