-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally expect heartbeats from the server #67
Comments
There was a lot of activity on this issue but it's still open. Does the feature work (and it should be closed)? |
Any update? |
It looks like all of this was on a "dev" branch that never got merged. Is there any plan to merge this into master and release it? |
The fix was way harder then anticipated and required major changes to the codebase, and eventually I gave up. Sorry. |
If you use primus on top of sockjs it will send these heartbeat packages for you. From client -> server and the server will automatically disconnect if a heartbeat missing/timed out. See https://github.com/primus/primus#heartbeats-and-latency So if you really, this might be a viable option. |
Hi. This issue has been open for almost 5 years now. It was recently discussed in #297. Is there any plan to implement this feature? The client not being aware of the server disappearing from the network seems to be a major flaw. What is the "dev" branch mentioned above that has never been merged if one wants to take a look at it? |
Are there any plans in implementing this issue? Is there any work around ? |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
The server may send an option telling the client how often it will send 'heartbeat' frames.
We should read this option and, indeed, expect heartbeats. We should kill the session on a heartbeat miss.
The text was updated successfully, but these errors were encountered: