Fix exception when slider doesn't have a head note

nicoco007 · Oct 28, 2024 · e0bf7fe · e0bf7fe
1 parent cbd9aca
commit e0bf7fe
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/Source/CustomAvatar/Utilities/BeatmapObjectEventFilter.cs b/Source/CustomAvatar/Utilities/BeatmapObjectEventFilter.cs
@@ -125,6 +125,12 @@ private bool ParentWasAlreadyTriggered(NoteController noteController, NoteCutRes
 
             NoteData headNote = GetHeadNote(noteData);
 
+            // TODO: handle sliders with no head note properly
+            if (headNote == null)
+            {
+                return true;
+            }
+
             if (_noteCutResults.TryGetValue(headNote, out NoteCutResult existingResult))
             {
                 if (existingResult.HasFlag(noteCutResult))
@@ -145,7 +151,7 @@ private bool ParentWasAlreadyTriggered(NoteController noteController, NoteCutRes
 
         private NoteData GetHeadNote(NoteData noteData)
         {
-            return _burstSliderHeadNoteDatas.First(nd => nd.time <= noteData.time && nd.colorType == noteData.colorType);
+            return _burstSliderHeadNoteDatas.FirstOrDefault(nd => nd.time <= noteData.time && nd.colorType == noteData.colorType);
         }
 
         [Flags]