Skip to content

Commit

Permalink
apache#1199: fix lint
Browse files Browse the repository at this point in the history
  • Loading branch information
nicolaferraro committed Feb 22, 2020
1 parent 8060428 commit e55b705
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions pkg/cmd/install.go
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,7 @@ func (o *installCmdOptions) printOutput(collection *kubernetes.Collection) error
return nil
}

// nolint:errcheck
func (o *installCmdOptions) waitForPlatformReady(cmd *cobra.Command, platform *v1.IntegrationPlatform) error {
handler := func(i *v1.IntegrationPlatform) bool {
if i.Status.Phase == v1.IntegrationPlatformPhaseReady || i.Status.Phase == v1.IntegrationPlatformPhaseError {
Expand Down
1 change: 1 addition & 0 deletions pkg/cmd/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ func (o *runCmdOptions) run(cmd *cobra.Command, args []string) error {
return nil
}

// nolint:errcheck
func (o *runCmdOptions) waitForIntegrationReady(cmd *cobra.Command, integration *v1.Integration) (*v1.IntegrationPhase, error) {
handler := func(i *v1.Integration) bool {
//
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ func Add(mgr manager.Manager) error {
// newReconciler returns a new reconcile.Reconciler
func newReconciler(mgr manager.Manager, c client.Client) reconcile.Reconciler {
return &ReconcileIntegrationPlatform{
client: c,
scheme: mgr.GetScheme(),
client: c,
scheme: mgr.GetScheme(),
recorder: mgr.GetEventRecorderFor("camel-k-integration-platform-controller"),
}
}
Expand Down
1 change: 1 addition & 0 deletions pkg/event/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ func NotifyBuildError(ctx context.Context, c client.Client, recorder record.Even
recorder.Eventf(p, corev1.EventTypeWarning, ReasonBuildError, "Cannot reconcile Build %s: %v", p.Name, err)
}

// nolint:lll
func notifyIfPhaseUpdated(ctx context.Context, c client.Client, recorder record.EventRecorder, new runtime.Object, oldPhase, newPhase string, resourceType, name, reason string) {
// Update information about phase changes
if oldPhase != newPhase {
Expand Down
1 change: 0 additions & 1 deletion pkg/util/watch/watch.go
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@ func HandleIntegrationEvents(ctx context.Context, integration *v1.Integration,
}
}


//
// HandlePlatformStateChanges watches a platform resource and invoke the given handler when its status changes.
//
Expand Down

0 comments on commit e55b705

Please sign in to comment.