Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDDL files #2

Merged
merged 8 commits into from
Jan 25, 2023
Merged

CDDL files #2

merged 8 commits into from
Jan 25, 2023

Conversation

GeorgeFlerovsky
Copy link

@GeorgeFlerovsky GeorgeFlerovsky commented Jan 24, 2023 •
edited
Loading

No description provided.

@nicolasayotte
Copy link
Owner

We agreed to add a bit of precision on the asset label types. Something like

bytes_32 = bytes .size (0..32)
label_utf8_32 = text .size (0..32) ; utf-8 encoded
label_hex_64 = text .size (0..64) ; hex encoded bytes_32

then merge.

@nicolasayotte
Copy link
Owner

This will allow the CSV format to support both types of labels, probably used a version tag to tell the user what to expect

@nicolasayotte nicolasayotte self-requested a review January 24, 2023 15:57
@nicolasayotte nicolasayotte added the documentation Improvements or additions to documentation label Jan 24, 2023
@GeorgeFlerovsky
Isolate CDDL for text-based (policy_id,asset_name)
0042fa1 
This corresponds to the CIP-25's version_1.cddl.
@GeorgeFlerovsky
Add support for bytestring (policy_id, asset_name)
839218c 
This corresponds to CIP-25's version_2.cddl.
Note that regex and tabular updates are not supported under this
version 2 mode.
@GeorgeFlerovsky GeorgeFlerovsky changed the title (DRAFT) CDDL file CDDL files Jan 24, 2023
@GeorgeFlerovsky GeorgeFlerovsky marked this pull request as ready for review January 24, 2023 19:55
@GeorgeFlerovsky
Copy link
Author

This will allow the CSV format to support both types of labels, probably used a version tag to tell the user what to expect

I split the CDDL file into two files (version_1.cddl and version_2.cddl). In version two, the action object sets version to 2.

@nicolasayotte
Update version_1.cddl
2fc06b6 
typo in text_32 definition
@nicolasayotte
Update version_2.cddl
182ccd1 
typo in text_32 definition
@nicolasayotte nicolasayotte merged commit fcb3cab into nicolasayotte:nft-metadata-oracle Jan 25, 2023
@GeorgeFlerovsky GeorgeFlerovsky deleted the nft-metadata-oracle-cddl branch January 25, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasayotte nicolasayotte nicolasayotte approved these changes

Assignees

@GeorgeFlerovsky GeorgeFlerovsky

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeorgeFlerovsky @nicolasayotte