Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two more themes + Bump for release V1.22. #64

Merged
merged 5 commits into from
Sep 11, 2023

Conversation

pserwylo
Copy link
Collaborator

@pserwylo pserwylo commented Sep 9, 2023

Fixes #57.

Two themes added: Pastel + Rainbow. Refactored the way themes work to make it easier to define key colours.

This release will also include the dutch translations from #61.

Previously the main colour and the pressed colour were
defined far apart from eachother. Now they are coupled
together into the KeyColour class.
See nicolasbrailo#57 for discussion of themes
that lead to these.
Copy link
Collaborator

@juleskers juleskers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

I have a minor nitpick over "colour"/"color", but other than that, looks mergeable to me! 👍

app/src/main/java/com/nicobrailo/pianoli/Theme.java Outdated Show resolved Hide resolved
app/src/main/java/com/nicobrailo/pianoli/Theme.java Outdated Show resolved Hide resolved
app/src/main/java/com/nicobrailo/pianoli/Theme.java Outdated Show resolved Hide resolved
Rainbow is lighter, and pastel is from colorbrewer2.

Also reordered themes so most likely to be chosen are shown
first.
Using American English for the class in this file, but leaving elsewhere (that is a tomorrow problem for another PR ;)
@pserwylo
Copy link
Collaborator Author

Thanks for the feedback as always @juleskers. Hope your first day back was fine. I'll tag this so F-Droid can build.

@pserwylo pserwylo merged commit 56dcad4 into nicolasbrailo:master Sep 11, 2023
@juleskers
Copy link
Collaborator

You're welcome!
thanks for putting up with my obsession about colors/colours 😉
(🇦🇺Australian, nice!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overview of additional colour themes (support?)
2 participants