Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wf #6

Merged
merged 44 commits into from
Jul 6, 2020
Merged

Add wf #6

merged 44 commits into from
Jul 6, 2020

Conversation

nicolecastillo
Copy link
Owner

  • Adds folder with the scripts and the workflow file.

nicolecastillo and others added 30 commits June 22, 2020 13:21
@nicolecastillo
Add workflow file
6d92e77
@nicolecastillo
Add Dockerfile
2ab8271
@nicolecastillo
Add scripts
bd8cf9a
@nicolecastillo
Add scripts
ec46aa4
@nicolecastillo
Update download_dataset.sh
c34118b
@nicolecastillo
Update run_benchmark.sh
4db0a82
@nicolecastillo
Update run_higgs_xlearn.py
634eece
@nicolecastillo
Update run_liblinear.sh
2ae8ed3
@nicolecastillo
Add files
288380d
@nicolecastillo
Update wf.yml
6318d91
@ivotron
remove unused
b33a3bf
@ivotron
Add step logic directly to workflow
6951d32
@ivotron
Add step for building image as part of worfklow
7f621ed
@ivotron
Install liblinear and csv2libsvm in docker image
fe911a2
@ivotron
Make scripts executable
c23abda
@ivotron
Move scripts to parent dir
76ba5bb
@ivotron
Move Dockerfile to parent folder
9c2df00
@ivotron
Make scripts executable
c92b52a
@ivotron
Update path to dockerfile
0e5ca61
@nicolecastillo
Merge pull request #4 from ivotron/wf-tweaks
19a0039 
Wf tweaks
@nicolecastillo
Update Dockerfile
f8c592c
@nicolecastillo
Update run_benchmark.sh
6c398a1
@nicolecastillo
Update options in run_higgs_liblinear.py
2bc2c22
@nicolecastillo
Update run_higgs_xlearn.py
619e871
@nicolecastillo
Update run_liblinear.sh
55f1743
@nicolecastillo
Update run_xlearn.sh
4ed7824
@nicolecastillo
Add csv2libsvm.py file
2f0ce61
@nicolecastillo
Update wf.yml
4d41b10
@nicolecastillo
Update csv2libsvm.py
33ecdfe
@nicolecastillo
Add README.md file
fd70eb2
@nicolecastillo nicolecastillo requested a review from ivotron July 2, 2020 19:14
ivotron
ivotron requested changes Jul 4, 2020
View reviewed changes
Copy link
Collaborator

@ivotron ivotron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking really good! almost done

demo/classification/higgs/popper/README.md Outdated
git clone https://github.com/aksnzhy/xlearn.git
```

2. Install docker.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add a link to the installation instructions

demo/classification/higgs/popper/README.md Outdated Show resolved Hide resolved
demo/classification/higgs/popper/README.md Show resolved Hide resolved
demo/classification/higgs/popper/Dockerfile Show resolved Hide resolved
demo/classification/higgs/popper/Dockerfile Outdated Show resolved Hide resolved
@nicolecastillo
Copy link
Owner Author

report

@nicolecastillo
Update README.md
317f18b
@nicolecastillo
Update Dockerfile
e40a6ad 
Added the checkout to a specific commit so that it always runs the same version.
ivotron
ivotron requested changes Jul 6, 2020
View reviewed changes
Copy link
Collaborator

@ivotron ivotron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice! The only thing I forgot to mention is that we can add 1-2 sentences to the README in the demo/higgs/ folder to mention that a comparison of xlearn with liblinear is included in the popper/ workflow.

@nicolecastillo
Copy link
Owner Author

Right! I'll get on it.

@ivotron ivotron merged commit 66f1d2a into popper Jul 6, 2020
@ivotron ivotron deleted the add-wf branch July 6, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivotron ivotron ivotron requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolecastillo @ivotron