feat: add support for TLA on node 14.3 and newer

[SimenB]

See babel/babel#12292

https://nodejs.org/en/blog/release/v14.3.0/

I'm unable to make this pass the tests, tho :( Weirdly, copying in the code here makes TLA work in a test in Jest repo, but I keep getting parser errors here. I tried updating @babel/core to latest just in case, but that didn't make a difference.

One interesting observation is that in Jest it only works if I use loadPartialConfig (which is what we use by default) - if I use loadOptions instead it fails with the same error it fails with here. However, I'm not having any luck replicating that behavior in this preset

[SimenB]

bug fix looking at the comment above

[SimenB]

I guess 15 doesn't matter, but anyways

[nicolo-ribaudo]

For the tests, maybe passing sourceType: "module" to

babel-preset-current-node-syntax/test/index.js

Line 19 in 6759da2

babel.parseSync(code, { configFile: false, presets: [thisPreset] });

is enough.

[SimenB]

sourceType: "module" makes no difference

[SimenB]

There's something else different between the Jest repo and this repo. If I don't have the syntax plugin in the preset in the Jest repo, I get this error

SyntaxError: /Users/simen/repos/jest/e2e/native-esm/__tests__/native-esm-tla.test.js: Can not use keyword 'await' outside an async function (8:14)

But the error I get in this repo - with or without the syntax plugin - is

SyntaxError: unknown: await is a reserved word (1:0)

I would have thought just using a newer version of @babel/core would fix that as it seems that error was improved, but this is using "@babel/core": "^7.0.0" in devDeps and refreshing the lockfile so everything should be at the latest version. This is with the follow parse call - I added a bunch of stuff just in case

babel.parseSync(code, {
  configFile: false,
  presets: [thisPreset],
  sourceType: "module",
  caller: {
    name: "syntax-preset-tester",
    supportsStaticESM: true,
    supportsDynamicImport: true,
    supportsTopLevelAwait: true,
    supportsExportNamespaceFrom: true,
  },
})

[nicolo-ribaudo]

Oh I checked the lockfile and it's still using @babel/parser 7.0.0, which doesn't support TLA

[SimenB]

Ah, I missed the resolutions entry! Unlocking @babel/core dev dep and @babel/parser resolution and then regenerating the lockfile makes the test pass. Thoughts on how to deal with it?

EDIT: Just removing the resolution work, the dev dep doesn't matter

[nicolo-ribaudo]

Ok so, the problem is that for the other tests we still need @babel/parser@7.0.0, otherwise some syntax features are enabled by default and we wouldn't be actually testing this preset.

@arcanis If I have this package.json

  "devDependencies": {
    "@babel/core@7.0.0": "npm:@babel/core@7.0.0",
    "@babel/core@7.9.0": "npm:@babel/core@7.9.0"
  },

Can I use resolutions to force @babel/core@7.0.0 to depend on @babel/parser@7.0.0, and @babel/core@7.9.0 on @babel/parser@7.9.0? I tried adding "@babel/core@7.0.0/@babel/parser": "7.0.0" but it doesn't seem to work.

[nicolo-ribaudo]

I think I found a fix.

[nicolo-ribaudo]

Tests are passing ✌️

[SimenB]

Yay! 🎉

[nicolo-ribaudo]

I'll release 1.0.0, since this project is "stable enough"

[SimenB]

wonderful, thanks!

[SimenB]

Bumped in jestjs/jest#10747, will release in v26 either this weekend or monday