Add setupFilesAfterEnv; run setupFiles before the env setup
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
force-pushed
the
fix-setupFiles
branch
2 times, most recently
from
f86b4a4
to
d681d69
Compare
nicolo-ribaudo
changed the title
setupFiles before installing Jest's globalssetupFilesAfterEnv, and run setupFiles before setting up the env
JLHwung
approved these changes
Apr 25, 2022
src/worker-runner.js
Outdated
| }; | ||
| let initialSetupP; | ||
| function initialSetup(projectConfig) { | ||
| initialSetupP ||= (async () => { |
There was a problem hiding this comment.
Suggested change
| initialSetupP ||= (async () => { | |
| initialSetupP ??= (async () => { |
nicolo-ribaudo
force-pushed
the
fix-setupFiles
branch
from
d681d69
to
dd6e80d
Compare
nicolo-ribaudo
changed the title
setupFilesAfterEnv, and run setupFiles before setting up the envsetupFilesAfterEnv; run setupFiles before the env setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to #16, I learned that the correct order is
setupFilessetupFilesAfterEnvWith this PR,
setupFilesis run once per global context.Fixes #16
cc @fisker The prettier tests still pass, but you might be interested in this.