Silently ignore rows that are not available #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triarius
changed the title
Previously, a "N/A" was printed, but I think looks nicer to just hide it.
triarius
force-pushed
the
triarius/ignore-na
branch
from
cda97c8
to
d1b7390
Compare
|
Heya! These look great from what I tested. There's only one minor detail - the I'll merge your changes and cherry-pick the commit with that refactor - although I still need to figure out a command to fetch macOS display adapters or ignore it. Overall I like these improvements a lot. Thanks for the updates @triarius! |
|
See associated cherry-picked commit at f749100 |
|
Thanks! I had something in the works for GPU too, and I left it alone as it was disabled anyway. Your change seems to work fine on Linux though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, an
N/Awas printed, but I think looks nicer to just hide it.The downside is that users will no longer know that something is missing. I can change it to print an error message in that case, but that could be annoying. If we want such error messages, I think we should make the visibility of certain info configurable so that users may hide it if it is erroring.
Fixes #4