fixed failing tests

nielse63 · Jan 12, 2023 · 2d613e6 · 2d613e6
1 parent 02f00e8
commit 2d613e6
Show file tree

Hide file tree

Showing 3 changed files with 117 additions and 114 deletions.
diff --git a/docs/api/finviz.md b/docs/api/finviz.md
@@ -8,8 +8,8 @@
 - [Installation](#installation)
 - [Usage](#usage)
 - [API](#api)
-  - [finviz.quote(symbol) ⇒ <code>Promise</code>](#finvizquotesymbol--promise)
-  - [finviz.screener(url) ⇒ <code>Promise</code>](#finvizscreenerurl--promise)
+  - [finviz.quote(symbol) ⇒ Promise](#finvizquotesymbol--promise)
+  - [finviz.screener(url) ⇒ Promise](#finvizscreenerurl--promise)
 - [Response schema](#response-schema)
 
 ## Features
@@ -94,6 +94,8 @@ const symbols = await finviz.screener(
 
 ## Response schema
 
+<!-- TODO: update this schedma -->
+
 ```js
 // pulled from https://finviz.com/quote.ashx?t=AACG
 {

diff --git a/packages/finviz/lib/__tests__/quote.spec.js b/packages/finviz/lib/__tests__/quote.spec.js
@@ -2,76 +2,76 @@ const quote = require('../quote');
 
 const symbol = 'AACG';
 const expectedKeys = [
-  'index',
-  'pE',
+  '52WHigh',
+  '52WLow',
+  '52WRange',
+  'atr',
+  'avgVolume',
+  'beta',
+  'bookSh',
+  'cashSh',
+  'change',
+  'currentRatio',
+  'debtEq',
+  'dividend',
+  'earnings',
+  'employees',
+  'epsNext5Y',
+  'epsNextQ',
+  'epsNextY',
+  'epsPast5Y',
+  'epsQQ',
+  'epsThisY',
   'epsTtm',
-  'insiderOwn',
-  'shsOutstand',
-  'perfWeek',
-  'marketCap',
   'forwardPE',
-  'epsNextY',
-  'insiderTrans',
-  'shsFloat',
-  'perfMonth',
+  'grossMargin',
   'income',
-  'peg',
-  'epsNextQ',
+  'index',
+  'insiderOwn',
+  'insiderTrans',
   'instOwn',
-  'shortFloat',
-  'perfQuarter',
-  'sales',
-  'pS',
-  'epsThisY',
   'instTrans',
-  'shortRatio',
-  'perfHalfY',
-  'bookSh',
+  'ltDebtEq',
+  'marketCap',
+  'operMargin',
+  'optionable',
   'pB',
-  'roa',
-  'targetPrice',
-  'perfYear',
-  'cashSh',
   'pC',
-  'epsNext5Y',
-  'roe',
-  '52WRange',
-  'perfYtd',
-  'dividend',
+  'pE',
   'pFcf',
-  'epsPast5Y',
-  'roi',
-  '52WHigh',
-  'beta',
+  'pS',
+  'payout',
+  'peg',
+  'perfHalfY',
+  'perfMonth',
+  'perfQuarter',
+  'perfWeek',
+  'perfYear',
+  'perfYtd',
+  'prevClose',
+  'price',
+  'profitMargin',
   'quickRatio',
+  'recom',
+  'relVolume',
+  'roa',
+  'roe',
+  'roi',
+  'rsi14',
+  'sales',
   'salesPast5Y',
-  'grossMargin',
-  '52WLow',
-  'atr',
-  'employees',
-  'currentRatio',
   'salesQQ',
-  'operMargin',
-  'rsi14',
-  'volatility',
-  'optionable',
-  'debtEq',
-  'epsQQ',
-  'profitMargin',
-  'relVolume',
-  'prevClose',
+  'shortFloatRatio',
+  'shortInterest',
   'shortable',
-  'ltDebtEq',
-  'earnings',
-  'payout',
-  'avgVolume',
-  'price',
-  'recom',
+  'shsFloat',
+  'shsOutstand',
   'sma20',
-  'sma50',
   'sma200',
+  'sma50',
+  'targetPrice',
+  'volatility',
   'volume',
-  'change',
 ];
 
 describe('quote', () => {

diff --git a/packages/quote/__tests__/index.spec.js b/packages/quote/__tests__/index.spec.js
@@ -1,76 +1,77 @@
 const quote = require('..');
 
+const symbol = 'MSFT';
 const expectedKeys = [
-  'index',
-  'pE',
+  '52WHigh',
+  '52WLow',
+  '52WRange',
+  'atr',
+  'avgVolume',
+  'beta',
+  'bookSh',
+  'cashSh',
+  'change',
+  'currentRatio',
+  'debtEq',
+  'dividend',
+  'earnings',
+  'employees',
+  'epsNext5Y',
+  'epsNextQ',
+  'epsNextY',
+  'epsPast5Y',
+  'epsQQ',
+  'epsThisY',
   'epsTtm',
-  'insiderOwn',
-  'shsOutstand',
-  'perfWeek',
-  'marketCap',
   'forwardPE',
-  'epsNextY',
-  'insiderTrans',
-  'shsFloat',
-  'perfMonth',
+  'grossMargin',
   'income',
-  'peg',
-  'epsNextQ',
+  'index',
+  'insiderOwn',
+  'insiderTrans',
   'instOwn',
-  'shortFloat',
-  'perfQuarter',
-  'sales',
-  'pS',
-  'epsThisY',
   'instTrans',
-  'shortRatio',
-  'perfHalfY',
-  'bookSh',
+  'ltDebtEq',
+  'marketCap',
+  'operMargin',
+  'optionable',
   'pB',
-  'roa',
-  'targetPrice',
-  'perfYear',
-  'cashSh',
   'pC',
-  'epsNext5Y',
-  'roe',
-  '52WRange',
-  'perfYtd',
-  'dividend',
+  'pE',
   'pFcf',
-  'epsPast5Y',
-  'roi',
-  '52WHigh',
-  'beta',
+  'pS',
+  'payout',
+  'peg',
+  'perfHalfY',
+  'perfMonth',
+  'perfQuarter',
+  'perfWeek',
+  'perfYear',
+  'perfYtd',
+  'prevClose',
+  'price',
+  'profitMargin',
   'quickRatio',
+  'recom',
+  'relVolume',
+  'roa',
+  'roe',
+  'roi',
+  'rsi14',
+  'sales',
   'salesPast5Y',
-  'grossMargin',
-  '52WLow',
-  'atr',
-  'employees',
-  'currentRatio',
   'salesQQ',
-  'operMargin',
-  'rsi14',
-  'volatility',
-  'optionable',
-  'debtEq',
-  'epsQQ',
-  'profitMargin',
-  'relVolume',
-  'prevClose',
+  'shortFloatRatio',
+  'shortInterest',
   'shortable',
-  'ltDebtEq',
-  'earnings',
-  'payout',
-  'avgVolume',
-  'price',
-  'recom',
+  'shsFloat',
+  'shsOutstand',
   'sma20',
-  'sma50',
   'sma200',
+  'sma50',
+  'targetPrice',
+  'volatility',
   'volume',
-  'change',
 ];
 
 describe('@stonksjs/quote', () => {
@@ -79,12 +80,12 @@ describe('@stonksjs/quote', () => {
   });
 
   it('should return an object', async () => {
-    const response = await quote('MSFT');
+    const response = await quote(symbol);
     expect(response).toBeObject();
   });
 
   it('response should have all expected keys', async () => {
-    const response = await quote('MSFT');
+    const response = await quote(symbol);
     expect(response).toContainKeys(expectedKeys);
   });
 });