Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/api #13

Merged
merged 15 commits into from
Jun 28, 2020
Merged

Feat/api #13

merged 15 commits into from
Jun 28, 2020

Conversation

nielse63
Copy link
Owner

No description provided.

@pull-assistant
Copy link

pull-assistant bot commented Jun 28, 2020

Score: 0.90

Best reviewed: commit by commit


Optimal code review plan (9 warnings)

latest

index.js 95% changes removed in updated scripts and ...

lib/sma.js 93% changes removed in updated scripts and ...

     moved bin folder

     updated project config and deps

created express app for api layer

api/routes/assets.js 58% changes removed in created backtest pat...

api/lib/Portfolio.js 77% changes removed in updated scripts and ...

created assets endpoint

api/routes/assets.js 50% changes removed in created backtest pat...

api/lib/Account.js 50% changes removed in added api lib tests

added api lib tests

.../lib/__tests__/Account.spec.js 41% changes removed in added buy/sell order...

api/routes/assets.js 44% changes removed in added buy/sell order...

...ib/__tests__/Portfolio.spec.js 66% changes removed in updated scripts and ...

added buy/sell order execution with stop limit sell

api/routes/assets.js 60% changes removed in removing unneeded fi...

created backtest path

api/lib/Asset.js 50% changes removed in updated scripts and ...

api/lib/Backtest.js 42% changes removed in updated scripts and ...

     removed calcSMA from Asset

created rebalaance script

api/lib/rebalancePortfolio.js 70% changes removed in updated scripts and ...

api/lib/Account.js 90% changes removed in updated scripts and ...

running scripts to manage account

api/lib/Portfolio.js 71% changes removed in updated scripts and ...

...thon/portfolio_optimization.py 49% changes removed in removing unneeded fi...

...lib/__tests__/Backtest.spec.js 92% changes removed in updated scripts and ...

python/new_portfolio.py 47% changes removed in removing unneeded fi...

     updated/created python scripts

updated scripts and lib

api/lib/Backtest.js 57% changes removed in removing unneeded fi...

...lib/__tests__/Backtest.spec.js 50% changes removed in removing unneeded fi...

.eslintrc.js 95% changes removed in removing unneeded fi...

     replaced python finviz script with node finviz script

     removing unneeded files

Powered by Pull Assistant. Last update 5a8da1c ... bf1e191. Read the comment docs.

@nielse63 nielse63 merged commit 977f3ae into master Jun 28, 2020
@nielse63 nielse63 deleted the feat/api branch June 28, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant